Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Pin dependencies in Pipfile #989

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Pin dependencies in Pipfile #989

merged 1 commit into from
Oct 28, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 26, 2022 •
edited
Loading

Fixes

Fixes #971 by @sarayourfriend

Description

This PR

  • pins the package versions in Pipfile to the minor version using the ~= syntax
  • simplifies strange = {version = "<version>"} syntax to = "<version>"
  • orders dependencies in alphabetical order

Testing Instructions

All tests are passing locally. CI is passing with freshly built containers. Seems adequate to me.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner October 26, 2022 14:55
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 26, 2022
@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited
Loading

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/989

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

sarayourfriend
sarayourfriend approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Out of curiosity, what process did you follow to do this? Did you have to copy the versions out of the lock file by hand? 😰

@dhruvkb
Copy link
Member Author

dhruvkb commented Oct 27, 2022

No I froze dependencies to a txt file using pip freeze and then wrote a script to remove all lines from the file that did not appear in the Pipfile. It only took a little bit of manual copying after that.

AetherUnbound
AetherUnbound approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and to the ingestion server too! 😄

@dhruvkb dhruvkb merged commit 24ad315 into main Oct 28, 2022
@dhruvkb dhruvkb deleted the pin_deps branch October 28, 2022 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@AetherUnbound AetherUnbound AetherUnbound approved these changes

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-api

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add versions to Pipfile
4 participants
@dhruvkb @AetherUnbound @sarayourfriend @openverse-bot